Revive ripple-client-desktop

Update: as of Jan 15, 2019, trading is working.

https://github.com/r0bertz/ripple-client-desktop

The first goal is to make it fully functional with RippleAPI.

Current status is most read only operations are working except order book.

Please follow this twitter thread for the most recent updates:

Comments

pucksterpete said…
Hello r0bertz,
I just read your article about "Why to use regular key and disable master key and How to do it with ripple-desktop-client"
and I was wondering if you be able to tell me if this fork version of the ripple-desktop-client is using secp256k1 signatures?

https://github.com/rippex/ripple-client-desktop---UNMAINTAINED

This version I am using since early 2017 comes from a person called Rafael, he is the ceo of Rippex, an old ripple gateway from Brazil I believe. Once an active member of XRPCHAT.
Here is the link to his introduction for the wallet on XRPCHAT from 2016.

https://www.xrpchat.com/topic/1215-desktop-wallet-an-alternative-to-rippletrade/

clip from his post
"Because we think its very important to keep the Master Key totally private, since it is the ultimate authority over a ripple account. The desktop client does that by creating and saving the wallet files locally, never sending it over the internet, not even in an encrypted channel.

The desktop client has all the necessary functions to create wallets (even cold wallets), watch accounts, pay, trade, and manage account flags. There are other potential functions like offline signing that are developed but still require some bug killing. Another important working feature is creating and revoking regular keys. This is awesome because it allows managing an account without using the Master Key, so the later can be kept totally private and offline, and used only in an emergency situation."

Thanks & keep writing GREAT articles

Pete
4/22/2019 2:24 PM
r0bertz said…
It looks like it depends on the key:

https://github.com/ripple/ripple-keypairs/blob/9402975731d33f7eddc51489544a2fc75c3bf353/src/index.js#L86
4/22/2019 3:11 PM
r0bertz said…
I dug a bit more.

To be clear, I didn't touch the code that generates address. So it is the same as ripple/ripple-client-desktop. Here is the code https://github.com/ripple/ripple-client-desktop/blob/3a23c50610fe75b0742fffbb3d2f342e99ffb742/src/js/util/types.js#L44

It appears to be using a curve called NIST P-256 (not secp256k1). But the strength seems to be the same. See https://github.com/bitwiseshiftleft/sjcl/wiki/Asymmetric-Crypto. Also since the public key is not prefixed with 0xED (see the first link), so you can think of it as secp256k1. Ripple's doc also says that secp256k1 is the default key type. https://developers.ripple.com/cryptographic-keys.html#signing-algorithms

So if you created your address using ripple-client-desktop, your key is secp256k1.

The problem, however, is not about the software that generates key. It's the one that signs transactions. In my fork, I use RippleAPI.sign function. https://github.com/r0bertz/ripple-client-desktop/blob/5000d979cbdb7bc892b184d1845c340f83d23b6c/src/js/services/network.js#L85

This function calls the sign function of ripple-keypairs https://github.com/ripple/ripple-lib/blob/f6a22d2121097289cf43dd31d8d45d249dd67589/src/transaction/sign.ts#L15

ripple-keypairs is a more recent project https://github.com/ripple/ripple-keypairs/commits/master/src/index.js

So it should be safe.
4/22/2019 9:26 PM
r0bertz said…
Also, what Rafael said about the client applies to my fork too. I didn't change anything in that regard.
4/22/2019 9:51 PM
pucksterpete said…
Okay, thank you for your explanation on this. I feel more comfortable now.
4/23/2019 4:11 AM
Robet Lont said…
Hi, Robert. Do you have the .exe file of the desktop wallet? I cannot build it and need it to restore my wallet. :( Thanks a lot!
6/25/2019 6:10 AM
r0bertz said…
Hi, Robet, I don't have one yet. I will post the link to it on my twitter r0bertz@ once I have it.
6/25/2019 9:38 AM
Post a Comment

Popular posts from this blog

portage-2.2 preserve-libs FEATURES explained

Maybe I am not the right person to write about it. But I felt the necessity to write about it. So I will just write something about preserve-libs, leaving other FEATURES to more competent people. Portage-2.2 has already entered unstable tree. Many people has started using it. It has many new features, like preserve-libs, sets, license filter and so on. Please check README and RELEASE-NOTES for a complete list. I will only talk about preserve-libs. To understand why we need it, we have to know some background information. First of all, applications are not built from scratch. Any non trivial apps use lot of libraries. In GNU/Linux, most of them are shared libraries, i.e. .so files. You can use `ldd /usr/bin/mplayer` to check what shared libraries an app has been linked to, replace mplayer to whatever program you'd like to check. Shared libraries have versions. E.g. /usr/lib/libavformat.so.51, here 51 denotes its version. After upgrading, the version number may change. E.g. /usr/lib/
Read more

Send $SGB (Songbird) to another wallet using a script

You need nodejs and web3 to run it:  const Web3 = require('web3'); // Variables definition const privKey = '8xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx2'; // Genesis private key const addressFrom = '0xAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA'; const addressTo = '0xBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB'; const web3 = new Web3('https://songbird.towolabs.com/rpc'); // Create transaction const deploy = async () => { console.log( `Attempting to make transaction from ${addressFrom} to ${addressTo}` ); const createTransaction = await web3.eth.accounts.signTransaction( { from: addressFrom, to: addressTo, value: web3.utils.toWei('1', 'ether'), // Send 1 SGB. 'ether' is not a typo here. gasPrice: web3.utils.toWei('225', 'Gwei'), gas: '21000', }, privKey ); // Deploy transaction const createR
Read more

The diff between the original SEC complaint against Ripple and the amended one

--- original.txt 2021-02-18 18:32:43.171832036 -0800 +++ amended.txt 2021-02-18 18:32:29.103735165 -0800 @@ -1,4 +1,4 @@ -Case 1:20-cv-10832 Document 4 Filed 12/22/20 Page 1 of 71 +Case 1:20-cv-10832-AT Document 46 Filed 02/18/21 Page 1 of 79 Richard Best Kristina Littman @@ -34,9 +34,9 @@ : ------------------------------------------------------------------------x -20 Civ. 10832 +20 Civ. 10832 (AT) ECF Case -Complaint +First Amended Complaint Jury Trial Demanded Plaintiff Securities and Exchange Commission (the “SEC”), for its Complaint against @@ -53,7 +53,7 @@ required by the federal securities laws, and no exemption from this requirement applied. 1 -Case 1:20-cv-10832 Document 4 Filed 12/22/20 Page 2 of 71 +Case 1:20-cv-10832-AT Document 46 Filed 02/18/21 Page 2 of 79 2. @@ -103,7 +103,7 @@ 2 -Case 1:20-cv-10832 Document 4 Filed 12/22/20 Page 3 of 71 +Case 1:20-cv-10832-AT Document 46 Filed 02/18/21 Page 3 of 79 VIOLATIONS 9. @@ -150,
Read more